Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Add const to local variables where possible. #74

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 17, 2024

To reproduce:

run-clang-tidy \
  -checks="-*,misc-const-correctness" \
  -p _build \
  -fix \
  $(find . -name "*.h" -or -name "*.cpp" | grep -v "/_build/")

This change is Reviewable

@iphydf iphydf added this to the v1.18.0 milestone Nov 17, 2024
@github-actions github-actions bot added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Nov 17, 2024
@iphydf iphydf modified the milestones: v1.18.0, v1.18.x, v1.18.1 Nov 17, 2024
@iphydf iphydf modified the milestones: v1.18.1, v1.18.x Jan 1, 2025
@iphydf iphydf force-pushed the const branch 6 times, most recently from 4faf631 to dee4bb1 Compare January 14, 2025 01:01
@iphydf iphydf modified the milestones: v1.18.x, v1.18.3 Jan 14, 2025
@iphydf iphydf force-pushed the const branch 2 times, most recently from f8cecdf to 239afa0 Compare January 14, 2025 01:04
src/chatlog/chatmessage.cpp Outdated Show resolved Hide resolved
To reproduce:
```
run-clang-tidy \
  -checks="-*,misc-const-correctness" \
  -p _build \
  -fix \
  $(find . -name "*.h" -or -name "*.cpp" | grep -v "/_build/")
```
@pull-request-attention pull-request-attention bot assigned Green-Sky and unassigned iphydf Jan 15, 2025
@iphydf iphydf merged commit e34b977 into TokTok:master Jan 15, 2025
30 of 31 checks passed
@iphydf iphydf deleted the const branch January 15, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants