Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Use = default instead of {} for default ctors. #81

Merged
merged 1 commit into from
Jan 7, 2025
Merged

cleanup: Use = default instead of {} for default ctors. #81

merged 1 commit into from
Jan 7, 2025

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 18, 2024 •
edited
Loading

Also remove redundant virtual when functions are already marked as override. Also use nullptr more.

run-clang-tidy -p _build -fix \
  $(find . -name "*.h" -or -name "*.cpp" -or -name "*.c" | grep -v "/_build/") \
  -checks="-*,modernize-use-equals-*,modernize-use-nullptr,modernize-use-override"

This change is Reviewable

@iphydf iphydf added this to the v1.18.0 milestone Nov 18, 2024
@github-actions github-actions bot added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Nov 18, 2024
@iphydf iphydf modified the milestones: v1.18.0, v1.18.x, v1.18.1 Nov 18, 2024
robinlinden
robinlinden approved these changes Nov 26, 2024
View reviewed changes
src/core/toxid.cpp Outdated Show resolved Hide resolved
@iphydf iphydf modified the milestones: v1.18.1, v1.18.x Jan 1, 2025
@iphydf iphydf force-pushed the default branch 2 times, most recently from 579ae7d to 7f2df25 Compare January 6, 2025 14:43
@iphydf iphydf force-pushed the default branch 7 times, most recently from 7050123 to 7f017a3 Compare January 7, 2025 18:05
@iphydf iphydf modified the milestones: v1.18.x, v1.18.2 Jan 7, 2025
@iphydf iphydf force-pushed the default branch 2 times, most recently from 5c13f9e to e7c7534 Compare January 7, 2025 19:10
@iphydf
cleanup: Use = default instead of {} for default ctors.
1fae365 
Also remove redundant `virtual` when functions are already marked as
`override`. Also use `nullptr` more.

```sh
run-clang-tidy -p _build -fix \
  $(find . -name "*.h" -or -name "*.cpp" -or -name "*.c" | grep -v "/_build/") \
  -checks="-*,modernize-use-equals-*,modernize-use-nullptr,modernize-use-override"
```
@iphydf iphydf requested a review from a team as a code owner January 7, 2025 19:24
@pull-request-attention pull-request-attention bot assigned Green-Sky and unassigned iphydf Jan 7, 2025
@pull-request-attention pull-request-attention bot assigned iphydf and unassigned Green-Sky Jan 7, 2025
@toktok-releaser toktok-releaser merged commit 1fae365 into TokTok:master Jan 7, 2025
32 checks passed
@iphydf iphydf deleted the default branch January 7, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinlinden robinlinden robinlinden approved these changes

@Green-Sky Green-Sky Green-Sky approved these changes

Assignees

@robinlinden robinlinden

@iphydf iphydf

Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Milestone
v1.18.2
Development

Successfully merging this pull request may close these issues.
4 participants
@iphydf @Green-Sky @robinlinden @toktok-releaser