Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add desktop notifications support on Linux. #98

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 18, 2024

This was broken with Qt6 because there's no Qt6 snorenotify. Now it only works on Linux, but we can add more backends for other systems later.


This change is Reviewable

@iphydf iphydf added this to the v1.18.0 milestone Nov 18, 2024
@github-actions github-actions bot added the enhancement New feature for the user, not a new feature for build script label Nov 18, 2024
@iphydf iphydf force-pushed the linux-notify branch 9 times, most recently from 627d3a9 to 9a4dbd4 Compare November 21, 2024 09:06
Copy link
Member

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

This was broken with Qt6 because there's no Qt6 snorenotify. Now it only
works on Linux, but we can add more backends for other systems later.
@toktok-releaser toktok-releaser merged commit edbbee9 into TokTok:master Nov 22, 2024
25 checks passed
@iphydf iphydf deleted the linux-notify branch November 22, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature for the user, not a new feature for build script
Development

Successfully merging this pull request may close these issues.

3 participants