Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Fix a few issues #106

Merged
merged 1 commit into from
Nov 2, 2020
Merged

cleanup: Fix a few issues #106

merged 1 commit into from
Nov 2, 2020

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented Nov 2, 2020 •
edited
Loading

  • realloc needs to be error checked
  • use correct format specifiers
  • make sure optarg and DATA_FILE aren't null before using them

This change is Reviewable

@JFreegman JFreegman added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Nov 2, 2020
@JFreegman JFreegman added this to the 0.8.x milestone Nov 2, 2020
robinlinden
robinlinden approved these changes Nov 2, 2020
View reviewed changes
src/term_mplex.c Show resolved Hide resolved
@JFreegman
Fix a few issues
1bbd50a 
- realloc needs to be error checked
- use correct format specifiers
- make sure optarg and DATA_FILE aren't null before using them
@JFreegman JFreegman merged commit 1bbd50a into TokTok:master Nov 2, 2020
@JFreegman JFreegman deleted the realloc branch November 2, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinlinden robinlinden robinlinden approved these changes

Assignees

@JFreegman JFreegman

Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Projects
None yet
Milestone
v0.8.x
Development

Successfully merging this pull request may close these issues.
2 participants
@JFreegman @robinlinden