cleanup: Remove legacy code and more code cleanup #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFreegman
added
the
cleanup
JFreegman
force-pushed
the
legacy_code
branch
3 times, most recently
from
98f1db3 to
8d41ff9
Compare
This code was added over 5 years ago and no longer serves a purpose
JFreegman
force-pushed
the
legacy_code
branch
from
8d41ff9 to
a86884c
Compare
JFreegman
changed the title
robinlinden
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy profile code was added over 5 years ago and no longer serves a purpose.
edit: added a few more null checks for
optargs, some missingmallocnull checks, and fixed a comparison between awidecharandchar.This change is