fix: Race condition #119
Merged
fix: Race condition #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFreegman
force-pushed
the
notify_race_condition
branch
4 times, most recently
from
3957507 to
53c4e09
Compare
DeepCode failed to analyze this pull requestSomething went wrong despite trying multiple times, sorry about that. |
JFreegman
force-pushed
the
notify_race_condition
branch
from
53c4e09 to
c5f849c
Compare
robinlinden
requested changes
Nov 10, 2020
JFreegman
force-pushed
the
notify_race_condition
branch
from
c5f849c to
2743fa1
Compare
JFreegman
force-pushed
the
notify_race_condition
branch
2 times, most recently
from
1d33441 to
6dd9b6e
Compare
A ToxWindow's notifications need to be halted before the window is freed
JFreegman
force-pushed
the
notify_race_condition
branch
from
6dd9b6e to
752fc6d
Compare
robinlinden
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ToxWindow's notifications need to be halted before the window is freed
This change is