fix: some off by one bugs with line scrolling and some cleanup #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFreegman
added
bug
JFreegman
force-pushed
the
scroll_fix
branch
from
8556c76 to
5ad31bc
Compare
JFreegman
changed the title
JFreegman
force-pushed
the
scroll_fix
branch
from
5ad31bc to
3d46371
Compare
|
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
JFreegman
force-pushed
the
scroll_fix
branch
5 times, most recently
from
5a67660 to
d6f4ffc
Compare
robinlinden
approved these changes
Nov 24, 2020
Instead of trying (and failing) to correctly calculate the number of lines on the screen a given message will need space for, we dynamically set the value both on initiation of a new line, and whenever that line is printed to the screen using the print_wrap() function. This should fix the screen occasionally not scrolling down the correct number of lines when a new message is printed.
JFreegman
force-pushed
the
scroll_fix
branch
from
d6f4ffc to
4122fab
Compare
It should now parse messages with newlines properly as well as messages that contain long sequences of characters with no spaces
JFreegman
force-pushed
the
scroll_fix
branch
from
4122fab to
d35a387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying (and failing) to correctly calculate the number of lines on the screen a given message will need space for, we dynamically set the value both on initiation of a new line, and whenever that line is printed to the screen using the
print_wrap()function.This should fix the screen occasionally not scrolling down the correct number of lines when a new message is printed.
Edit: Also fixed an issue with the line format breaking if a line contained newlines or no spaces
This change is