-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add config option for the notification timeout duration #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1.
Reviewable status: 0 of 1 approvals obtained
@kitsunenokenja You'll need to sign your commit before it can be merged. |
You used the |
If this last update didn't work I'll revisit later to work out the settings for GPG signing. |
We still can't merge because you haven't uploaded your public key to github in order to verify your signatures. I know it's annoying, but you only have to set it up once. See: https://help.github.com/articles/adding-a-new-gpg-key-to-your-github-account/ |
I already use GPG signing with the Gentoo project here on GitHub. Now I need to sort out the config for working with |
@JFreegman, sorry for the delay! I believe this is ready now. |
Re-created PR per maintainer's request.
This change enhances the default setting of 3000 milliseconds for the notification timeout by making the value a user config option.
This change is