Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add config option for the notification timeout duration #38

Merged
merged 1 commit into from
Nov 10, 2018
Merged

feat: Add config option for the notification timeout duration #38

merged 1 commit into from
Nov 10, 2018

Conversation

kitsunenokenja
Copy link

@kitsunenokenja kitsunenokenja commented Nov 6, 2018

Re-created PR per maintainer's request.

This change enhances the default setting of 3000 milliseconds for the notification timeout by making the value a user config option.


This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 6 of 6 files at r1.
Reviewable status: 0 of 1 approvals obtained

@JFreegman
Copy link
Member

@kitsunenokenja You'll need to sign your commit before it can be merged.

@JFreegman
Copy link
Member

You used the -s option (sign off) instead of -S (sign with gpg key)

@kitsunenokenja
Copy link
Author

If this last update didn't work I'll revisit later to work out the settings for GPG signing.

@JFreegman
Copy link
Member

JFreegman commented Nov 6, 2018

We still can't merge because you haven't uploaded your public key to github in order to verify your signatures. I know it's annoying, but you only have to set it up once. See: https://help.github.com/articles/adding-a-new-gpg-key-to-your-github-account/

@kitsunenokenja
Copy link
Author

kitsunenokenja commented Nov 6, 2018

I already use GPG signing with the Gentoo project here on GitHub. Now I need to sort out the config for working with -S on another repo. I'll amend again as soon as I can.

@kitsunenokenja
Copy link
Author

@JFreegman, sorry for the delay! I believe this is ready now.

@JFreegman JFreegman merged commit f7b73af into TokTok:master Nov 10, 2018
@iphydf iphydf added this to the 0.8.x milestone Apr 26, 2020
@iphydf iphydf changed the title Add config option for the notification timeout duration feat: Add config option for the notification timeout duration May 4, 2020
@auto-add-label auto-add-label bot added the enhancement New feature for the user, not a new feature for build script label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature for the user, not a new feature for build script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants