Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Load conference titles on startup for saved conferences #43

Merged
merged 1 commit into from
Jun 30, 2019
Merged

feat: Load conference titles on startup for saved conferences #43

merged 1 commit into from
Jun 30, 2019

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented Jun 26, 2019 •
edited by iphydf
Loading

This change is Reviewable

@anthonybilinski
Copy link

anthonybilinski commented Jun 26, 2019 •
edited
Loading

just a heads up that tox_conference_get_title_size can return 0 if no group name has been set, and tox_conference_get_title errors if a length of 0 is passed in, even though the group is still otherwise valid.

@JFreegman JFreegman force-pushed the load_conference_title branch from 363b3a9 to fe515f9 Compare June 26, 2019 18:23
@JFreegman
Copy link
Member Author

JFreegman commented Jun 26, 2019 •
edited
Loading

@anthonybilinski

just a heads up that tox_conference_get_title_size can return 0 if no group name has been set, and tox_conference_get_title error if a length of 0 is passed in.

Fixed. Strange beaviour though. Why would a function set an error when a valid value is returned?

robinlinden
robinlinden approved these changes Jun 30, 2019
View reviewed changes
Copy link
Member

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 6 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@JFreegman JFreegman merged commit bb22579 into TokTok:master Jun 30, 2019
@iphydf iphydf added this to the 0.8.x milestone Apr 26, 2020
@JFreegman JFreegman deleted the load_conference_title branch May 4, 2020 22:04
@iphydf iphydf changed the title Load conference titles on startup for saved conferences feat: Load conference titles on startup for saved conferences May 4, 2020
@auto-add-label auto-add-label bot added the enhancement New feature for the user, not a new feature for build script label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinlinden robinlinden robinlinden approved these changes

Assignees
No one assigned
Labels
enhancement New feature for the user, not a new feature for build script
Projects
None yet
Milestone
v0.8.x
Development

Successfully merging this pull request may close these issues.
4 participants
@JFreegman @anthonybilinski @robinlinden @iphydf