Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add input line text to history on UP and DOWN keys #46

Merged
merged 1 commit into from Dec 7, 2019
Merged

feat: Add input line text to history on UP and DOWN keys #46

merged 1 commit into from Dec 7, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 7, 2019

This change is Reviewable

@claassistantio
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@JFreegman
Copy link
Member

The commit needs to be signed before merging

@JFreegman
Copy link
Member

You need to sign the actual commit via git using a public key associated with your github account. git commit -S -m "commit message"

See: https://help.github.com/en/github/authenticating-to-github/signing-commits

@ghost
Copy link
Author

ghost commented Dec 7, 2019

That's what I've done

@JFreegman
Copy link
Member

You need to add your public key to your github account. When you look at the commit it should show a green "verified" button.

@ghost
Copy link
Author

ghost commented Dec 7, 2019

Done

@JFreegman JFreegman merged commit ddeca17 into TokTok:master Dec 7, 2019
@iphydf iphydf added this to the 0.8.x milestone Apr 26, 2020
@iphydf iphydf changed the title Add input line text to history on UP and DOWN keys feat: Add input line text to history on UP and DOWN keys May 4, 2020
@auto-add-label auto-add-label bot added the enhancement New feature for the user, not a new feature for build script label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature for the user, not a new feature for build script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants