Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Some misc fixes #49

Merged
merged 1 commit into from
Mar 7, 2020
Merged

fix: Some misc fixes #49

merged 1 commit into from
Mar 7, 2020

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented Feb 29, 2020 •
edited by iphydf
Loading

Self explanatory.

This change is Reviewable

nurupo
nurupo approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time seeing -Wpedantic, always used -pedantic instead.

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

nurupo
nurupo approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@robinlinden
Copy link
Member

First time seeing -Wpedantic, always used -pedantic instead.

Yeah, they added -Wpedantic way later. They don't have a -W variant of -pedantic-errors which enables diagnostics not enabled by -pedantic (so it's not just -Werror=pedantic, it is stricter/better than that!)

@JFreegman
Copy link
Member Author

Does anyone know what's wrong with travis and how to fix it?

@iphydf iphydf merged commit 437dd8b into TokTok:master Mar 7, 2020
@iphydf
Copy link
Member

iphydf commented Mar 7, 2020

They moved to the new "Checks" API. Fixed.

@iphydf iphydf added this to the 0.8.x milestone Apr 26, 2020
@JFreegman JFreegman deleted the fixes branch May 4, 2020 22:04
@iphydf iphydf changed the title Some misc fixes fix: Some misc fixes May 4, 2020
@auto-add-label auto-add-label bot added the bug Bug fix for the user, not a fix to a build script label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nurupo nurupo nurupo approved these changes

Assignees
No one assigned
Labels
bug Bug fix for the user, not a fix to a build script
Milestone
v0.8.x
Development

Successfully merging this pull request may close these issues.
4 participants
@JFreegman @robinlinden @iphydf @nurupo