Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Fix unused parameter warnings and add -Wunused-parameter to makefile #55

Merged
merged 1 commit into from
Mar 15, 2020

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented Mar 15, 2020

Addressing issue #53


This change is Reviewable

Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it doesn't fix the issue. The issue is about unused-result, not unused-parameter.

@JFreegman JFreegman force-pushed the unused-parameter branch 4 times, most recently from 29122b8 to 132f1ad Compare March 15, 2020 18:53
@JFreegman JFreegman merged commit 98cb7f5 into TokTok:master Mar 15, 2020
@iphydf iphydf added this to the 0.8.x milestone Apr 26, 2020
@JFreegman JFreegman deleted the unused-parameter branch May 4, 2020 22:04
@iphydf iphydf changed the title Fix unused parameter warnings and add -Wunused-parameter to makefile cleanup: Fix unused parameter warnings and add -Wunused-parameter to makefile May 4, 2020
@auto-add-label auto-add-label bot added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants