Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Half-hearted attempt at making toxic work on osx. #56

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Mar 30, 2020

Video has no chance without X11 for now.


This change is Reviewable

@iphydf iphydf requested a review from JFreegman March 30, 2020 12:36
@iphydf
Copy link
Member Author

iphydf commented Mar 30, 2020

@zoff99 nice, does it work on osx? Either way, probably worth sending a PR.

Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

I currently have no way of actually testing that this works, but it looks reasonable.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @JFreegman)

Video has no chance without X11 for now.
@iphydf iphydf merged commit 4651301 into TokTok:master Mar 30, 2020
@iphydf iphydf deleted the osx branch March 30, 2020 18:18
@iphydf iphydf added this to the 0.8.x milestone Apr 26, 2020
@iphydf iphydf changed the title Half-hearted attempt at making toxic work on osx. refactor: Half-hearted attempt at making toxic work on osx. May 4, 2020
@auto-add-label auto-add-label bot added the refactor Refactoring production code, eg. renaming a variable, not affecting semantics label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring production code, eg. renaming a variable, not affecting semantics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants