Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add feature flags and missing #includes. #64

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Apr 15, 2020

These are needed to compile on some strict Linuxes.


This change is Reviewable

These are needed to compile on some strict Linuxes.
@iphydf iphydf requested a review from JFreegman April 16, 2020 13:56
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 19 of 19 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @JFreegman)

@iphydf iphydf merged commit dd5fa23 into TokTok:master Apr 16, 2020
@iphydf iphydf deleted the feature-flags branch April 16, 2020 17:25
@iphydf iphydf added this to the 0.8.x milestone Apr 26, 2020
@iphydf iphydf changed the title Add feature flags and missing #includes. refactor: Add feature flags and missing #includes. May 4, 2020
@auto-add-label auto-add-label bot added the refactor Refactoring production code, eg. renaming a variable, not affecting semantics label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring production code, eg. renaming a variable, not affecting semantics
Development

Successfully merging this pull request may close these issues.

3 participants