Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option for toxcore logging in stderr #74

Merged
merged 1 commit into from
May 4, 2020

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented May 4, 2020

This change is Reviewable

doc/toxic.1 Outdated
@@ -78,6 +78,11 @@ instead of
Show help message
.RE
.PP
\-l, \-\-logging
.RS 4
Enable toxcore logging in stderr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "logging to stderr" as in "logging to a stream".

@iphydf iphydf added this to the 0.8.x milestone May 4, 2020
Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@JFreegman JFreegman merged commit 4bfb344 into TokTok:master May 4, 2020
@JFreegman JFreegman deleted the logger branch May 4, 2020 22:04
@iphydf iphydf changed the title Add option for toxcore logging in stderr feat: Add option for toxcore logging in stderr May 4, 2020
@auto-add-label auto-add-label bot added the enhancement New feature for the user, not a new feature for build script label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature for the user, not a new feature for build script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants