Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Wformat-truncation warnings due to snprintf() misuse #93

Merged
merged 1 commit into from
Oct 24, 2020
Merged

fix: Wformat-truncation warnings due to snprintf() misuse #93

merged 1 commit into from
Oct 24, 2020

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented Oct 24, 2020 •
edited by iphydf
Loading

This change is Reviewable

@JFreegman JFreegman added the bug Bug fix for the user, not a fix to a build script label Oct 24, 2020
@JFreegman JFreegman added this to the 0.8.x milestone Oct 24, 2020
robinlinden
robinlinden approved these changes Oct 24, 2020
View reviewed changes
Copy link
Member

@robinlinden robinlinden left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Builds completely without warnings locally now. :)

Edit: Obviously replacing things like + 30 with a define explaining what it is would be better, but this fixes all the warnings at least.

@JFreegman JFreegman merged commit 4c302da into TokTok:master Oct 24, 2020
@JFreegman JFreegman deleted the format_truncation branch October 24, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinlinden robinlinden robinlinden approved these changes

Assignees

@JFreegman JFreegman

Labels
bug Bug fix for the user, not a fix to a build script
Projects
None yet
Milestone
v0.8.x
Development

Successfully merging this pull request may close these issues.
2 participants
@JFreegman @robinlinden