Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TextEditor #173

Closed
MaxDesiatov opened this issue Jul 11, 2020 · 3 comments · Fixed by #329
Closed

Implement TextEditor #173

MaxDesiatov opened this issue Jul 11, 2020 · 3 comments · Fixed by #329
Labels
SwiftUI compatibility Tokamak API differences with SwiftUI

Comments

@MaxDesiatov
Copy link
Collaborator

This is probably going to be one of the most complex views, but definitely worth it and is something that I see that people are requesting.

@MaxDesiatov MaxDesiatov added the SwiftUI compatibility Tokamak API differences with SwiftUI label Jul 11, 2020
@mcritz
Copy link

mcritz commented Dec 5, 2020

+1 for this. TextEditor (in SwiftUI 2020) is nearly one-for-one with <textarea>

MaxDesiatov added a commit that referenced this issue Dec 7, 2020
@MaxDesiatov MaxDesiatov changed the title Implement TextEditor Implement TextEditor Dec 7, 2020
MaxDesiatov added a commit that referenced this issue Dec 7, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Add `TextEditor` implementation

Resolves #173.

* Clean up and bump requirements in the demo project

* Use a single `_tokamak-formcontrol` CSS class

* Add missing CSS class to `TextEditor.swift`

Co-authored-by: Jed Fox <git@jedfox.com>

Co-authored-by: Jed Fox <git@jedfox.com>
@mcritz
Copy link

mcritz commented Dec 8, 2020

Thank you very much!

@MaxDesiatov
Copy link
Collaborator Author

Thanks for helping us prioritize this! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SwiftUI compatibility Tokamak API differences with SwiftUI
Development

Successfully merging a pull request may close this issue.

2 participants