Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Environment #135

Merged
merged 4 commits into from
Jul 1, 2020
Merged

Implement Environment #135

merged 4 commits into from
Jul 1, 2020

Conversation

carson-katri
Copy link
Member

@Environment, and .environment should both work.

@carson-katri
Copy link
Member Author

IMO any new EnvironmentKeys should be done in separate PRs.

@TokamakUI TokamakUI deleted a comment from ie-ahm-robox Jun 30, 2020
@carson-katri carson-katri added the SwiftUI compatibility Tokamak API differences with SwiftUI label Jun 30, 2020
MaxDesiatov
MaxDesiatov reviewed Jun 30, 2020
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just started working on colorScheme prompted by your mention of GitHub's lack of dark mode support, but then stumbled upon the fact that Environment doesn't work in main. Just a few suggestions, looking forward to it being merged!

@MaxDesiatov MaxDesiatov mentioned this pull request Jun 30, 2020
Merged
@carson-katri
Copy link
Member Author

carson-katri commented Jul 1, 2020 •
edited
Loading

I fixed some of the long lines then swiftformat made them one line again 😄

I’ve gotta check the formatting more closely.

@TokamakUI TokamakUI deleted a comment from ie-ahm-robox Jul 1, 2020
@carson-katri carson-katri requested a review from MaxDesiatov July 1, 2020 12:21
MaxDesiatov
MaxDesiatov approved these changes Jul 1, 2020
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@carson-katri carson-katri merged commit 1d71fe0 into main Jul 1, 2020
@carson-katri carson-katri deleted the environment branch July 1, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ie-ahm-robox ie-ahm-robox ie-ahm-robox left review comments

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
SwiftUI compatibility Tokamak API differences with SwiftUI
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carson-katri @MaxDesiatov @ie-ahm-robox