Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Xcode project and native targets #142

Merged
merged 9 commits into from
Jul 2, 2020
Merged

Add Xcode project and native targets #142

merged 9 commits into from
Jul 2, 2020

Conversation

j-f1
Copy link
Member

@j-f1 j-f1 commented Jul 1, 2020

This makes the demo run on iOS and macOS. I slimmed down the Xcode project as much as possible to keep it light.

@j-f1 j-f1 added the enhancement New feature or request label Jul 1, 2020
@carson-katri
Copy link
Member

You could probably slim it down even more if you use the SwiftUI lifecycle

@j-f1
Copy link
Member Author

j-f1 commented Jul 1, 2020

I could but I don't think apps written with it will run on non-beta OSes atm

@MaxDesiatov
Copy link
Collaborator

The build is failing with this error:

/github/workspace/Sources/TokamakDOM/Tokens/Tokens.swift:22:57: error: cannot find 'alpha' in scope
    "rgb(\(red * 255), \(green * 255), \(blue * 255), \(alpha * 255))"

MaxDesiatov
MaxDesiatov approved these changes Jul 2, 2020
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@j-f1 j-f1 merged commit e652691 into main Jul 2, 2020
@j-f1 j-f1 deleted the native-build branch July 2, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ie-ahm-robox ie-ahm-robox ie-ahm-robox left review comments

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j-f1 @carson-katri @MaxDesiatov @ie-ahm-robox