-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Image
implementation, bump JSKit to 0.9.0
#155
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
678361f
Add Image view
j-f1 b8c0422
Add image to demo
j-f1 ab02c4a
Update progress.md
j-f1 6cdf44d
Alt text
j-f1 ebd692f
Merge branch 'main' of github.com:swiftwasm/Tokamak into image
MaxDesiatov f4c1887
Merge branch 'main' of github.com:swiftwasm/Tokamak into image
MaxDesiatov 1f6fb33
Use Bundle type to load images, remove systemName
MaxDesiatov 513bc21
Add `logo-header.png` resource to `TokamakDemo`
MaxDesiatov aedb7ff
Reduce image size in the demo
MaxDesiatov 2e33b99
Allow bundles passed to `Image` to be optional
MaxDesiatov 2cac41b
Pass `nil` as a default `bundle` to `Image`
MaxDesiatov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
// Copyright 2018-2020 Tokamak contributors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// | ||
// Created by Jed Fox on 07/01/2020. | ||
// | ||
|
||
import Foundation | ||
|
||
public struct Image: View { | ||
let label: Text? | ||
let name: String | ||
let bundle: Bundle? | ||
|
||
public init(_ name: String, bundle: Bundle? = nil) { | ||
label = Text(name) | ||
self.name = name | ||
self.bundle = bundle | ||
} | ||
|
||
public init(_ name: String, bundle: Bundle? = nil, label: Text) { | ||
self.label = label | ||
self.name = name | ||
self.bundle = bundle | ||
} | ||
|
||
public init(decorative name: String, bundle: Bundle? = nil) { | ||
label = nil | ||
self.name = name | ||
self.bundle = bundle | ||
} | ||
|
||
public var body: Never { | ||
neverBody("Image") | ||
} | ||
} | ||
|
||
/// This is a helper class that works around absence of "package private" access control in Swift | ||
public struct _ImageProxy { | ||
public let subject: Image | ||
|
||
public init(_ subject: Image) { self.subject = subject } | ||
|
||
public var labelString: String? { subject.label?.storage.rawText } | ||
public var name: String { subject.name } | ||
public var path: String? { subject.bundle?.path(forResource: subject.name, ofType: nil) } | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
// Copyright 2020 Tokamak contributors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// | ||
// Created by Max Desiatov on 11/04/2020. | ||
// | ||
|
||
import TokamakCore | ||
|
||
public typealias Image = TokamakCore.Image | ||
|
||
extension Image: ViewDeferredToRenderer { | ||
public var deferredBody: AnyView { | ||
AnyView(_HTMLImage(proxy: _ImageProxy(self))) | ||
} | ||
} | ||
|
||
struct _HTMLImage: View { | ||
let proxy: _ImageProxy | ||
public var body: some View { | ||
var attributes: [HTMLAttribute: String] = [ | ||
"src": proxy.path ?? proxy.name, | ||
"style": "max-width: 100%; max-height: 100%", | ||
] | ||
if let label = proxy.labelString { | ||
attributes["alt"] = label | ||
} | ||
return AnyView(HTML("img", attributes)) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think to match some of SwiftUI's
Image
modifiers we'll need to implement the internal storage as anAnyTokenBox
. Then once we add support for things like template images we can access the environment to render them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for highlighting this, I've created #312 to track it.