-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @EnvironmentObject #170
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ba17ce2
Initial EnvironmentObject impl
carson-katri 2505ca9
Pull observable-object branch of OpenCombine
MaxDesiatov 3a41603
Add ObservedObject implementation
MaxDesiatov b9da18a
Setup subscriptions in the reconciler
MaxDesiatov 7fd940e
Update .swift-version to the latest snapshot
MaxDesiatov a1ada48
Merge observed-object
carson-katri 5f8f02e
Resolve conflicts
carson-katri 5f0b374
Resolve environment injection issues
carson-katri 1187772
Fix demo
carson-katri aa4d33d
Formatting fixes
carson-katri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
// Copyright 2020 Tokamak contributors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// | ||
// Created by Carson Katri on 7/7/20. | ||
// | ||
|
||
import OpenCombine | ||
|
||
protocol EnvironmentWriter { | ||
func subscribe(_ closure: @escaping () -> ()) | ||
} | ||
|
||
@propertyWrapper public struct EnvironmentObject<ObjectType>: EnvironmentReader, EnvironmentWriter where ObjectType: ObservableObject { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
@dynamicMemberLookup public struct Wrapper { | ||
internal let root: ObjectType | ||
public subscript<Subject>(dynamicMember keyPath: ReferenceWritableKeyPath<ObjectType, Subject>) -> Binding<Subject> { | ||
Binding { | ||
root[keyPath: keyPath] | ||
} set: { | ||
root[keyPath: keyPath] = $0 | ||
} | ||
} | ||
} | ||
|
||
var _store: ObjectType? | ||
var _seed: Int = 0 | ||
|
||
mutating func setContent(from values: EnvironmentValues) { | ||
_store = values[ObjectIdentifier(ObjectType.self)] | ||
} | ||
|
||
func subscribe(_ closure: @escaping () -> ()) { | ||
_ = _store?.objectWillChange.sink { _ in | ||
print("EnvironmentObject changed!") | ||
closure() | ||
} | ||
} | ||
|
||
public var wrappedValue: ObjectType { | ||
guard let store = _store else { error() } | ||
return store | ||
} | ||
|
||
public var projectedValue: Wrapper { | ||
guard let store = _store else { error() } | ||
return Wrapper(root: store) | ||
} | ||
|
||
func error() -> Never { | ||
fatalError("No ObservableObject found for type \(ObjectType.self)") | ||
} | ||
|
||
public init() {} | ||
} | ||
|
||
extension ObservableObject { | ||
static var environmentStore: WritableKeyPath<EnvironmentValues, Self?> { | ||
\.[ObjectIdentifier(self)] | ||
} | ||
} | ||
|
||
extension View { | ||
public func environmentObject<B>(_ bindable: B) -> some View where B: ObservableObject { | ||
environment(B.environmentStore, bindable) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,5 +61,6 @@ struct TokamakDemoView: View { | |
} | ||
} | ||
} | ||
.environmentObject(TestEnvironment()) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line_length
)