Remove _AnyApp, add Renderer.AppType associated type
#225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/TokamakCore/App/_AnyScene.swift # Sources/TokamakCore/MountedViews/MountedApp.swift # Sources/TokamakCore/MountedViews/MountedElement.swift # Sources/TokamakCore/StackReconciler.swift
j-f1
reviewed
Jul 29, 2020
Co-authored-by: Jed Fox <git@jedfox.com>
|
Closing this as outdated. The original crash was resolved, and this branch has diverged from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #224
This introduces a crash in the scene environment code and I'm still not sure why all known crashes are gone in #223. Keeping this as a draft until we get more clarity on how to resolve this.