Fix color scheme observer crashes in Safari #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It’s probably because I’m using Safari Technology Preview (Release 110, Safari 14.0, WebKit 15610.1.21.0.2). |
j-f1
approved these changes
Aug 5, 2020
|
Huh, I thought that Safari TP is completely broken because of swiftwasm/carton#25 |
|
Yeah, I’m using a local override on |
|
I'm also using that override to use Safari on Big Sur. |
carson-katri
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #245. Turns out
matchMediaDarkSchemeobject doesn't haveaddEventListener, but onlyaddListenerin Safari 13.1.2. IDK why this wasn't reproduced elsewhere, maybe it was changed in Safari minor version that you don't have yet?¯\_(ツ)_/¯