Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set versions of dependencies in Package.swift #262

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented Aug 17, 2020

This allows specifying 0.3 (to be released after this PR is merged) dependency on Tokamak in carton templates, otherwise branch/commit dependencies in our Package.swift can't be correctly resolved.

swift test is temporarily disabled on macOS as the upstream Swift toolchain doesn't support unsafe flags in the JavaScriptKit dependency together with a from constraint. We could run it on Linux, but my OpenCombine fork doesn't support Linux builds yet (logged as #263).

@MaxDesiatov MaxDesiatov added the dependencies Updates to the project dependencies label Aug 17, 2020
@MaxDesiatov MaxDesiatov marked this pull request as draft August 17, 2020 18:20
@MaxDesiatov MaxDesiatov marked this pull request as ready for review August 17, 2020 19:10
@MaxDesiatov
Copy link
Collaborator Author

@j-f1 I hope to tag new releases of both Tokamak and carton in the next few days, so merging this early to test carton templates. LMK if you have any objections, I can revert or submit a follow-up PR.

@MaxDesiatov MaxDesiatov merged commit 82111c5 into main Aug 19, 2020
@MaxDesiatov MaxDesiatov deleted the specify-dependencies branch August 19, 2020 09:08
@j-f1
Copy link
Member

j-f1 commented Aug 21, 2020

LGTM! Was on vacation so couldn’t review.

@j-f1 j-f1 removed their request for review August 21, 2020 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates to the project dependencies
Development

Successfully merging this pull request may close these issues.

3 participants