Support spacing property on HStack/VStack
#273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
added
bug
|
Definitely reasonable to use grids for Stacks at least until |
|
Yeah, I have no problems with using grid. |
|
CSS Grid is a great way to support child spacing! I wrote about using them in React here. Would love to help out with this if you're looking for contributors 🙂 |
|
We're always looking for contributors, thank you for the offer! Please feel free to open a PR even if you just started working on this. You can mark it as a draft even if it's work in progress, that will let everyone know what you're working on. Just open an issue if you see any problems or need any help! 🙂 |
# Conflicts: # NativeDemo/TokamakDemo.xcodeproj/project.pbxproj # Sources/TokamakDOM/App/App.swift # Sources/TokamakDOM/Core.swift
MaxDesiatov
force-pushed
the
stack-spacing
branch
from
a028f18 to
ff5335c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's much easier to implement stack spacing when stacks are rendered as single-row or single-column grids, and grid gaps already work in all browsers. For this we need to slightly bump browser version requirements, most notably from Safari 11 to Safari 12.
Resolves #272.