Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build the GTK renderer on Ubuntu on CI #347

Merged
merged 8 commits into from
Jan 13, 2021
Merged

Build the GTK renderer on Ubuntu on CI #347

merged 8 commits into from
Jan 13, 2021

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented Jan 2, 2021 •
edited
Loading

We should make sure that our reconciler and renderer code also builds on Ubuntu.

This PR also contains some formatting changes, which were done by the latest version of SwiftFormat.

@MaxDesiatov MaxDesiatov added continuous integration Changes related to the continuous integration process GTK renderer Extending GTK support labels Jan 2, 2021
@mortenbekditlevsen
Copy link
Contributor

Hi @MaxDesiatov ,
I recently tried building on Ubuntu 20.04 and get the same 'CRuntime' import errors.
Do you know what they are?

@MaxDesiatov
Copy link
Collaborator Author

I didn't do a very thorough investigation, seems that the Runtime dependency in OpenCombine is causing issues. I'm going to replace it with a plain Mirror implementation as an attempt to fix it. Just need to cherry-pick OpenCombine/OpenCombine#201 into our fork of OpenCombine, which I'm going to do later today.

@MaxDesiatov MaxDesiatov added the dependencies Updates to the project dependencies label Jan 11, 2021
@MaxDesiatov MaxDesiatov marked this pull request as ready for review January 11, 2021 15:58
@MaxDesiatov MaxDesiatov requested review from a team January 11, 2021 16:00
@mortenbekditlevsen
Copy link
Contributor

I can now build and run TokamakGTKDemo - and it's great to see it running on Ubuntu!

Currently nothing re-renders when state changes, but I don't know if that has anything to do with the changes to OpenCombine with regards to Runtime.

mortenbekditlevsen
mortenbekditlevsen approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@mortenbekditlevsen mortenbekditlevsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All workflow and Makefile changes looks good to me.
As I mentioned the TokamakGTKDemo does not re-render at state changes, but I don't know if that has anything to do with the 0.12.0-alpha3 version of OpenCombine or not (since I haven't been able to build on Ubuntu before).

@MaxDesiatov
Copy link
Collaborator Author

Makes sense. I think lack of updates needs to be investigated separately.

@MaxDesiatov MaxDesiatov merged commit 3a0f8a8 into main Jan 13, 2021
@MaxDesiatov MaxDesiatov deleted the gtk-ubuntu-ci branch January 13, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenbekditlevsen mortenbekditlevsen mortenbekditlevsen approved these changes

Assignees
No one assigned
Labels
continuous integration Changes related to the continuous integration process dependencies Updates to the project dependencies GTK renderer Extending GTK support
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @mortenbekditlevsen