-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add '_spi(TokamakCore)' to ideally internal public members. #386
Changes from 8 commits
b4968f3
8e1a31c
3dd0f1e
7ccc3a4
89e9aaa
4a59cfd
0b845fd
75f3051
b408a4e
13117ec
71b27b8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,13 +19,10 @@ public struct Group<Content> { | |
} | ||
} | ||
|
||
extension Group: View where Content: View { | ||
public var body: Never { | ||
neverBody("Group") | ||
} | ||
} | ||
extension Group: PrimitiveView & View where Content: View {} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason that it's conforming to both PrimitiveView and View? Is the former not a refinement of the latter? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, conditionally conforming a type to a "refining" protocol (such as Also, I have no preference as to whether the above is written as |
||
|
||
extension Group: ParentView where Content: View { | ||
@_spi(TokamakCore) | ||
public var children: [AnyView] { (content as? ParentView)?.children ?? [AnyView(content)] } | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you apply SwiftFormat as
swiftformat .
in the project directory to get rid of trailing whitespaces? You can also install a pre-commit hook as described here, which will apply formatting fixes automatically for you before you commit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I had forgotten that.