Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DOMRenderer to render buttons with non-Text labels (#403) #409

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Allow DOMRenderer to render buttons with non-Text labels (#403) #409

merged 1 commit into from
Jun 7, 2021

Conversation

ezraberch
Copy link
Member

@ezraberch ezraberch commented Jun 7, 2021 •
edited by MaxDesiatov
Loading

Currently, DOMRenderer can only handle Buttons where is the label is Text. If it is any other View, the Button is not rendered. This is the cause of #403.

This PR removes this restriction. Additionally, it expands the ButtonStyle demo to include Buttons with complex labels.

@MaxDesiatov MaxDesiatov added the SwiftUI compatibility Tokamak API differences with SwiftUI label Jun 7, 2021
MaxDesiatov
MaxDesiatov approved these changes Jun 7, 2021
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MaxDesiatov MaxDesiatov merged commit da9843d into TokamakUI:main Jun 7, 2021
@MaxDesiatov MaxDesiatov mentioned this pull request Jun 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
SwiftUI compatibility Tokamak API differences with SwiftUI
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ezraberch @MaxDesiatov