Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check minWidth/Height == nil #420

Merged
merged 4 commits into from
Jul 9, 2021
Merged

Check minWidth/Height == nil #420

merged 4 commits into from
Jul 9, 2021

Conversation

carson-katri
Copy link
Member

@carson-katri carson-katri commented Jul 8, 2021

Resolves #387

This also updates frame layouts to respect the alignment parameter.

@carson-katri carson-katri added the bug Something isn't working label Jul 8, 2021
@carson-katri
Copy link
Member Author

carson-katri commented Jul 9, 2021

I couldn't see any visual difference in the opacity test, so I replaced the image. If you do see a difference please let me know and I'l try to resolve it. (Github has some nice features for diffing images like onion-skin and a slider mode).

@carson-katri carson-katri requested a review from a team July 9, 2021 12:51
@MaxDesiatov MaxDesiatov added the DOM/HTML renderer Tokamak in the browser label Jul 9, 2021
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👏

@carson-katri carson-katri merged commit 30f55d9 into main Jul 9, 2021
@carson-katri carson-katri deleted the flex-frame-fix branch July 9, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DOM/HTML renderer Tokamak in the browser
Development

Successfully merging this pull request may close these issues.

Frame sizes do not match expected behavior.
2 participants