Fix SwiftLint action #434
Merged
Fix SwiftLint action #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezraberch
added
the
continuous integration
MaxDesiatov
reviewed
Jul 28, 2021
| @@ -12,7 +12,11 @@ jobs: | |||
| runs-on: ubuntu-20.04 | |||
| steps: | |||
| - uses: actions/checkout@v1 | |||
| - name: Fetch base ref | |||
| run: | | |||
| git fetch --prune --no-tags --depth=1 origin +refs/heads/${{ github.base_ref }}:refs/heads/${{ github.base_ref }} | |||
There was a problem hiding this comment.
Can you add a comment here that clarifies the purpose of this step?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Github Action for SwiftLint is currently not working properly. Here is a recent example. It is not only linting the changed files. In fact, it is linting files multiple times, leading to nearly 5000 files being linted in the example. This leads to warnings being repeated multiple times.
The core issue is norio-nomura/action-swiftlint#38. Unfortunately, that bug has not been fixed in that repository, so I switched to the mayk-it/action-swift-lint fork. However, newer versions of action-swiftlint use a swift 5.4 version of SwiftLint, which will crash when linting this project (details). so I had to make my own fork which uses 5.3 (we're currently using 5.1).
Here is a run with the new version of the action.