Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for JSKit 0.11.1, add async task modifier #457

Merged
merged 20 commits into from
Nov 23, 2021
Merged

Update for JSKit 0.11.1, add async task modifier #457

merged 20 commits into from
Nov 23, 2021

Conversation

MaxDesiatov
Copy link
Collaborator

I've also moved sources in TokamakDemo directory into their respective subdirectories for easier navigation

@MaxDesiatov MaxDesiatov added SwiftUI compatibility Tokamak API differences with SwiftUI DOM/HTML renderer Tokamak in the browser labels Nov 22, 2021
@MaxDesiatov MaxDesiatov requested a review from a team November 22, 2021 13:27
@MaxDesiatov
Add compiler #if check to TaskDemo
8932bd0
@MaxDesiatov
Update to JavaScriptKit 0.11.1
b65300f
@MaxDesiatov
Restrict TaskDemo with compiler(>=5.5) check
2ee9fc5
@MaxDesiatov
Replace compiler with swift in some places
534784c
@MaxDesiatov
Revert "Replace compiler with swift in some places"
7382291 
This reverts commit 534784c.
@MaxDesiatov
Use Xcode 13.2 on GitHub Actions hosts
63d044f
@MaxDesiatov
Find TokamakPackageTests in the build directory
68c845b
@MaxDesiatov
Fix macOS tests bundle path
3ccbc98
@MaxDesiatov
Make task modifier available only on macOS Monterey
bac82ce
@MaxDesiatov
Revert "Use Xcode 13.2 on GitHub Actions hosts"
4d25ff4 
This reverts commit 63d044f.
@MaxDesiatov
Revert "Fix macOS tests bundle path"
2fa2e3e 
This reverts commit 3ccbc98.
@MaxDesiatov
Revert "Find TokamakPackageTests in the build directory"
55001d2 
This reverts commit 68c845b.
@MaxDesiatov
Use canImport(Concurrency) as an ultimate check
05728f5
@MaxDesiatov
Use compiler(>=5.5) && canImport(Concurrency)
226fce6
@MaxDesiatov
Copy link
Collaborator Author

This is finally ready for review now, sorry for excessive notifications pinging with failed builds.

@MaxDesiatov MaxDesiatov changed the title Update for JSKit 0.11.0, add async task modifier Update for JSKit 0.11.1, add async task modifier Nov 22, 2021
MaxDesiatov
MaxDesiatov commented Nov 22, 2021
View reviewed changes
Sources/TokamakDemo/Modifiers/ShadowDemo.swift

import TokamakShim

struct ShadowDemo: View {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was moved from existing ShadowDemo.swift, but for some reason git didn't pick it up.

@yonihemi yonihemi mentioned this pull request Nov 23, 2021
Merged
yonihemi
yonihemi previously approved these changes Nov 23, 2021
View reviewed changes
ezraberch
ezraberch reviewed Nov 23, 2021
View reviewed changes
Package.swift Outdated Show resolved Hide resolved
ezraberch
ezraberch reviewed Nov 23, 2021
View reviewed changes
Copy link
Member

@ezraberch ezraberch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Readme should be updated to specify new minimum carton version (which doesn't exist yet) and remove the note about Xcode 13.1 not being supported.

ezraberch
ezraberch reviewed Nov 23, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@MaxDesiatov @ezraberch
Update README.md
cf0ad83 
Co-authored-by: ezraberch <49635435+ezraberch@users.noreply.github.com>
@MaxDesiatov MaxDesiatov merged commit cbfdc34 into main Nov 23, 2021
@MaxDesiatov MaxDesiatov deleted the task-modifier branch November 23, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezraberch ezraberch ezraberch approved these changes

@yonihemi yonihemi yonihemi left review comments

Assignees
No one assigned
Labels
DOM/HTML renderer Tokamak in the browser SwiftUI compatibility Tokamak API differences with SwiftUI
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxDesiatov @yonihemi @ezraberch