Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Missing CoreGraphics import for Swift 5.7.1 / Xcode 14.1 #528

Merged
merged 1 commit into from
Nov 11, 2022
Merged

[bug] Missing CoreGraphics import for Swift 5.7.1 / Xcode 14.1 #528

merged 1 commit into from
Nov 11, 2022

Conversation

gregcotten
Copy link
Contributor

Fixes #527

@gregcotten
Copy link
Contributor Author

Hmm, looks like one of the layout tests failed with a timeout...

/Users/runner/work/Tokamak/Tokamak/Tests/TokamakStaticHTMLTests/RenderingTests/LayoutTests.swift:169: error: -[TokamakStaticHTMLTests.LayoutRenderingTests testStacks] : failed - Exceeded timeout of 10.0 seconds waiting for snapshot.

@gregcotten
Copy link
Contributor Author

@carson-katri could you re-run the CI? I think the timeout on macOS was not actually an issue with this PR.

@gregcotten gregcotten changed the title Missing CoreGraphics import for Swift 5.7.1 / Xcode 14.1 [Bug] Missing CoreGraphics import for Swift 5.7.1 / Xcode 14.1 Nov 7, 2022
@gregcotten gregcotten changed the title [Bug] Missing CoreGraphics import for Swift 5.7.1 / Xcode 14.1 [bug] Missing CoreGraphics import for Swift 5.7.1 / Xcode 14.1 Nov 7, 2022
@carson-katri carson-katri added the bug Something isn't working label Nov 7, 2022
carson-katri
carson-katri approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@carson-katri carson-katri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks 👍

@carson-katri carson-katri merged commit f1cbfcf into TokamakUI:main Nov 11, 2022
@gregcotten gregcotten deleted the missing-cggraphics-import branch December 3, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carson-katri carson-katri carson-katri approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building TokamakCore is broken in latest Xcode
2 participants
@gregcotten @carson-katri