Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kwargs data and unsafe_length #76

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Conversation

kescobo
Copy link
Contributor

@kescobo kescobo commented Oct 12, 2021

Fixes a couple of things that have deprecation warnings on nightly.

kwargs.data -> values(kwargs) (see JuliaLang/julia#39448)

and

Base.unsafe_length -> length (see JuliaLang/julia#40382)

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #76 (535df98) into master (add8f06) will increase coverage by 0.89%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   67.65%   68.55%   +0.89%     
==========================================
  Files          29       29              
  Lines        2288     2245      -43     
==========================================
- Hits         1548     1539       -9     
+ Misses        740      706      -34     
Impacted Files Coverage Δ
src/axis_array.jl 76.21% <100.00%> (ø)
src/named.jl 57.81% <100.00%> (+1.75%) ⬆️
src/abstractarray.jl 91.30% <0.00%> (-0.59%) ⬇️
src/linear_algebra.jl 87.66% <0.00%> (-0.24%) ⬇️
src/AxisIndices.jl 40.29% <0.00%> (+0.29%) ⬆️
src/struct_axis.jl 85.71% <0.00%> (+1.00%) ⬆️
src/arrays.jl 85.49% <0.00%> (+1.32%) ⬆️
src/offset_axis.jl 71.73% <0.00%> (+1.52%) ⬆️
src/centered_axis.jl 61.19% <0.00%> (+1.77%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add8f06...535df98. Read the comment docs.

@Tokazama Tokazama merged commit f7106e6 into Tokazama:master Oct 12, 2021
@Tokazama
Copy link
Owner

Thanks!

@kescobo kescobo deleted the kwargs-data branch October 12, 2021 16:28
@kescobo
Copy link
Contributor Author

kescobo commented Oct 12, 2021

Pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants