Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Made ico compatible with the latest version of populus and solidity #134

Closed
wants to merge 3 commits into from

Conversation

voith
Copy link
Collaborator

@voith voith commented Jun 17, 2018

What was wrong?

The ico repository was not compatible with the latest version of populus and solidity

How was it fixed?

checklist before merging

  • Make sure that populus.json has been properly translated to project.json.
  • Ask @miohtama and @petri If this needs more manual testing before merging. TokenMarketNet might have dependent code based on this change. So I'd need some help with integration testing.
  • submit fixes from my populus fork to the main repository and on merging the fixes make sure ico is pinned with a new release of populus.

@voith
Copy link
Collaborator Author

voith commented Jun 17, 2018

Marking this PR as WIP as some fixes from my populus fork need to be submitted upstream. All the tests are passing. I wanted to show case what changes are needed to get the test suite green!
cc @miohtama and @petri

@voith
Copy link
Collaborator Author

voith commented Jun 25, 2018

Update: I have added a new commit to this PR. For more context please see ethereum/populus#468. Earlier, I had fixed this in my fork. But since I found a workaround we don't really need to fix it!
New Checklist:

@voith
Copy link
Collaborator Author

voith commented Jun 25, 2018

@miohtama Did you know about ethereum/populus#468. It seems like you added command_line_options feature in ethereum/populus#331.

@voith
Copy link
Collaborator Author

voith commented Jun 25, 2018

Update: It turns out that the setting optimer: true was not working. This was causing some tests to run out of gas. I have fixed this in a new commit: fb15afe

@voith
Copy link
Collaborator Author

voith commented Aug 5, 2018

closing in favour of #139

@voith voith closed this Aug 5, 2018
@voith voith deleted the migrate-ico branch August 5, 2018 20:01
@voith voith restored the migrate-ico branch August 7, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant