[WIP] Made ico compatible with the latest version of populus and solidity #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The ico repository was not compatible with the latest version of
populus
andsolidity
How was it fixed?
py-solc
repository: support solidity versions > v0.4.19 ethereum/py-solc#53, added flag evm-verison to solc_wrapper ethereum/py-solc#55.verify_contract_bytecode
method and introducingevmVersion
in populus.travis.yml
to0.4.24
.requirements.txt
to pin the latest dependencies needed(There are some dependency issues with populus. However I fixed them by pinning them inrequirements.txt
)populus.json
was ported to the newproject.json
evm_version
was sethomestead
. Read https://medium.com/@chris_77367/explaining-unexpected-reverts-starting-with-solidity-0-4-22-3ada6e82308c for more details.TESTRPC_GAS_LIMIT = 6000000
as one test needs more gas. This seems wrong but I think this could be fixed. My suspect is populus which is not optimizing the bytecode as specified inpopulus.json
. I verified this from the bytecode that was generated in.cache
.checklist before merging
populus.json
has been properly translated toproject.json
.TokenMarketNet
might have dependent code based on this change. So I'd need some help with integration testing.