Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxify DvA manager and implement token freeze logic #204

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Proxify DvA manager and implement token freeze logic #204

merged 4 commits into from
Jun 20, 2024

Conversation

aliarbak
Copy link
Contributor

@aliarbak aliarbak commented Jun 14, 2024 •
edited
Loading

  • DvA Transfer Manager contract proxified
  • The DvA manager contract freezes the tokens to be transferred instead of being a vault (so it must be a token agent)
  • Only the token owner (rather than agents) can call setApprovalCriteria, as it is part of the main token settings.

@aliarbak aliarbak requested a review from Joachim-Lebrun June 14, 2024 11:30
@Joachim-Lebrun Joachim-Lebrun merged commit 0fb608a into develop Jun 20, 2024
3 checks passed
@Joachim-Lebrun Joachim-Lebrun deleted the proxify-dva branch June 20, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joachim-Lebrun Joachim-Lebrun Joachim-Lebrun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliarbak @Joachim-Lebrun