Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run mypy with --no-strict-optional #132

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Conversation

alexdrydew
Copy link
Contributor

@alexdrydew alexdrydew commented Nov 14, 2022

After the recent release of mypy type annotation must be Optional[...] or Union[None, ...] if default value is None. This is not the case with Toloka-Kit: the problem is that type annotations added in BaseTolokaObjectMetaclass.transform are not propogated to __init__ of the resulting class.

Since this check blocks merging any PRs now, let's disable it till the problem is fixed on our side.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation and examples improvement (changes affected documentation and/or examples)

Checklist:

  • I have read the CONTRIBUTING document.
  • I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DrhF
Copy link
Collaborator

DrhF commented Nov 14, 2022

Let's create an issue so as not to forget to fix this

@DrhF
Copy link
Collaborator

DrhF commented Nov 14, 2022

#133

@alexdrydew alexdrydew merged commit 34c1fc0 into main Nov 14, 2022
@alexdrydew alexdrydew deleted the no_strict_optional_mypy branch November 14, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants