Added note

TomAugspurger · Apr 27, 2018 · 6858409 · 6858409
1 parent eb43fa4
commit 6858409
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/pandas/core/arrays/base.py b/pandas/core/arrays/base.py
@@ -535,6 +535,10 @@ def take(self, indices, allow_fill=False, fill_value=None):
                if allow_fill and fill_value is None:
                    fill_value = self.dtype.na_value
 
+               # fill value should always be translated from the scalar
+               # type for the array, to the physical storage type for
+               # the data, before passing to take.
+
                result = take(data, indices, fill_value=fill_value,
                              allow_fill=allow_fill)
                return self._from_sequence(result)