Avoid disabling MenuToggleKey #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be avoided to flag the control for MenuToggleKey as disabled if there is no menu open.
Some scripts might want to perform specific actions based on control check state and do different based on if the control is enabled or disabled (or they can just don't care about the status but it's up to them). Having the MenuToggleKey flagged as disabled seems logically wrong as would never allow to such control to be enabled.
MenuAPI shouldn't flag any control as disabled for the entire lifetime of the script, it should only do it for the limited time required to perform its own checks.