Skip to content

Commit

Permalink
Fix for player overhead names not disapearing.
Browse files Browse the repository at this point in the history
For some reason in the code there was a for loop to iterate over players and not over the created gamertags dict. This resulted in mp gamer tags not disaprearing when checkbox unchecked.
  • Loading branch information
Explooosion-code authored Aug 27, 2020
1 parent 0be816e commit 5ab2e71
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions vMenu/FunctionsController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2343,9 +2343,9 @@ private async Task PlayerOverheadNamesControl()
bool enabled = MainMenu.MiscSettingsMenu.MiscShowOverheadNames && IsAllowed(Permission.MSOverheadNames);
if (!enabled)
{
for (var i = 0; i < 255; i++)
foreach (KeyValuePair<Player, int> gamerTag in gamerTags)
{
RemoveMpGamerTag(i);

This comment has been minimized.

Copy link
@Explooosion-code

Explooosion-code Aug 27, 2020

Author Contributor

This native takes MpGamerTagID not player local id (line 2348)

RemoveMpGamerTag(gamerTag.Value);
}
}
else
Expand Down

0 comments on commit 5ab2e71

Please sign in to comment.