Improvements for working with OneSync/Infinity. #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset abstracts away the PlayerList instance into two separate implementations: one forwarding directly to the local player list, and one which will be used if the server informs us that Infinity is indeed enabled.
TomGrobbe
reviewed
Oct 28, 2020
| /// <summary> | ||
| /// Runs join/quit notification checks. | ||
| /// </summary> | ||
| /// <returns></returns> | ||
| private async Task JoinQuitNotifications() | ||
| [EventHandler("vMenu:PlayerJoinQuit")] |
There was a problem hiding this comment.
I'll end up moving this to the events handler class but it's fine for now.
TomGrobbe
reviewed
Oct 28, 2020
| @@ -18,7 +19,7 @@ | |||
|
|
|||
| <Reference Include="Microsoft.CSharp" /> | |||
|
|
|||
| <PackageReference Include="CitizenFX.Core.Client" Version="1.0.2836"> | |||
| <PackageReference Include="CitizenFX.Core.Client" Version="1.0.*"> | |||
There was a problem hiding this comment.
this is neat, i gotta use this in my other references as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset abstracts away the PlayerList instance into two separate implementations: one forwarding directly to the local player list, and one which will be used if the server informs us that Infinity is indeed enabled.
Other than that, a few miscellaneous changes had to be made in order to work with the virtualized list.