Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for working with OneSync/Infinity. #233

Merged

Conversation

blattersturm
Copy link
Collaborator

@blattersturm blattersturm commented Oct 28, 2020

This changeset abstracts away the PlayerList instance into two separate implementations: one forwarding directly to the local player list, and one which will be used if the server informs us that Infinity is indeed enabled.

Other than that, a few miscellaneous changes had to be made in order to work with the virtualized list.

This changeset abstracts away the PlayerList instance into two separate implementations: one forwarding directly to the local player list, and one which will be used if the server informs us that Infinity is indeed enabled.
/// <summary>
/// Runs join/quit notification checks.
/// </summary>
/// <returns></returns>
private async Task JoinQuitNotifications()
[EventHandler("vMenu:PlayerJoinQuit")]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll end up moving this to the events handler class but it's fine for now.

@@ -18,7 +19,7 @@

<Reference Include="Microsoft.CSharp" />

<PackageReference Include="CitizenFX.Core.Client" Version="1.0.2836">
<PackageReference Include="CitizenFX.Core.Client" Version="1.0.*">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is neat, i gotta use this in my other references as well

Copy link
Owner

@TomGrobbe TomGrobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@TomGrobbe TomGrobbe merged commit 816b844 into TomGrobbe:development Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants