Added a 'destroy engine' button to Vehicle Options. #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would put the menu option before the delete option :D |
That's definitely not a bad idea! Thank you. |
TomGrobbe
reviewed
May 25, 2021
| // Destroy engine | ||
| else if (item == destroyEngine) | ||
| { | ||
| SetVehicleEngineHealth(vehicle.Handle, -4000); |
There was a problem hiding this comment.
Setting it to 0 should also kill it afaik, or maybe -1 should be good enough. I haven't tested it completely but let me know. Other than that this PR looks good.
|
Closing this PR because it's just been merged via PR #290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I received several requests for a 'Destroy Engine' button in the Vehicle Options submenu. So I made it and added it to the submenu. A preview of the feature can be seen here: https://streamable.com/saeycl