Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VehicleOptions] Added ability to select custom vehicle colours using RGB values #395

Merged

Conversation

JayPaulinCodes
Copy link
Contributor

Added to the primary and secondary colour menus a button to set to a custom RGB colour.

@blackfirefly000
Copy link
Contributor

I tested this out, and it breaks the color menu for other colors. The color labels do not match what the colors are. (For primary colors classic are metallic, metallic are matte, matte are metals, metals are util, util are worn, and worn doesn't work, and it's similar for secondary colors)

Fixes vehicle color menu not working correctly
@blackfirefly000
Copy link
Contributor

I have a made a fix and created a pull request to JayPaulinCodes:feature/customRgbColours. The pull request can be found here: JayPaulinCodes#1

@JayPaulinCodes
Copy link
Contributor Author

I have a made a fix and created a pull request to JayPaulinCodes:feature/customRgbColours. The pull request can be found here: JayPaulinCodes#1

It's funny you had mentioned this, I was just coming back to this to update that as I noticed it a day or 2 ago myself, thank you for the PR, I've merged it in! <3

@XdGoldenTigerOfficial XdGoldenTigerOfficial merged commit 3310944 into TomGrobbe:master Aug 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants