Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: histogram instead of density kernel #15

Closed
Jadamso opened this issue Apr 27, 2022 · 2 comments
Closed

Feature Request: histogram instead of density kernel #15

Jadamso opened this issue Apr 27, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Jadamso
Copy link
Contributor

Jadamso commented Apr 27, 2022

Thank you for a great package.

For some cases, it would be helpful to use a histogram rather than a kernel density. The ability to use R's hist function and breaks argument would be very easy to use. This functionality is also not currently available via ggplot.

@TomKellyGenetics
Copy link
Owner

Thanks for the suggestion, this requires a significant overhaul of the source code but I agree it would be possible to use this package a foundation to implement this. I'm unsure whether it is best to set up a new parameter with an "if" statement or if it is better to create a new function for back-to-back histograms. The "split" parameter would also allow for bihistograms to be created in R.

I'm open to accepting pull requests if you have time to implement this yourself.

@TomKellyGenetics TomKellyGenetics added enhancement New feature or request help wanted Extra attention is needed labels Nov 9, 2022
@TomKellyGenetics TomKellyGenetics changed the title Feature Request Feature Request: histogram instead of density kernel Nov 9, 2022
@TomKellyGenetics
Copy link
Owner

Addressed in open PR #18

TomKellyGenetics added a commit that referenced this issue Dec 8, 2022
  ensures CRAN checks and unit tests are passing (#15 #18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants