Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest gala, add a catch for slicing half-loaded files #128

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Use latest gala, add a catch for slicing half-loaded files #128

merged 4 commits into from
Aug 27, 2024

Conversation

TomWagg
Copy link
Owner

@TomWagg TomWagg commented Aug 27, 2024

  • Try and use the latest gala again
  • Ensure users have fully loaded a file before trying to index a pop from it, otherwise chaos ensues 😅

@TomWagg TomWagg added the development tests, automation, code improvements label Aug 27, 2024
@TomWagg TomWagg self-assigned this Aug 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1702 1702 100% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cogsworth/pop.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 6573ad9 by action🐍

@TomWagg
Copy link
Owner Author

TomWagg commented Aug 27, 2024

Thanks @adrn - it worked! :)

@TomWagg TomWagg merged commit e3dd5a2 into main Aug 27, 2024
2 checks passed
@TomWagg TomWagg deleted the gala branch August 27, 2024 07:09
@adrn
Copy link
Collaborator

adrn commented Aug 27, 2024

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TomWagg TomWagg

Labels
development tests, automation, code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomWagg @adrn