add similar test for static properties

TomasVotruba · Jul 19, 2024 · 577a168 · 577a168
1 parent d50653f
commit 577a168
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/tests/Rules/UnusedPublicPropertyRule/Fixture/PropertyUsedViaSubClass.php b/tests/Rules/UnusedPublicPropertyRule/Fixture/PropertyUsedViaSubClass.php
@@ -4,7 +4,7 @@
 
 namespace TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicPropertyRule\Fixture;
 
-class UseBaseClassViaSubClass
+class PropertyUsedViaSubClass
 {
     private SubClass $prop;
 

diff --git a/tests/Rules/UnusedPublicPropertyRule/Fixture/StaticPropertyUsedViaSubClass.php b/tests/Rules/UnusedPublicPropertyRule/Fixture/StaticPropertyUsedViaSubClass.php
@@ -0,0 +1,23 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicPropertyRule\Fixture;
+
+class StaticPropertyUsedViaSubClass
+{
+    private SubClass $prop;
+
+    protected function doFoo() {
+        $this->prop::$x = 1;
+    }
+}
+
+class SubClass extends BaseClass
+{
+}
+
+class BaseClass
+{
+    static public int $x;
+}
diff --git a/tests/Rules/UnusedPublicPropertyRule/UnusedPublicPropertyRuleTest.php b/tests/Rules/UnusedPublicPropertyRule/UnusedPublicPropertyRuleTest.php
@@ -32,6 +32,7 @@ public function testRule(array $filePaths, array $expectedErrorMessagesWithLines
     public static function provideData(): Iterator
     {
         yield [[__DIR__ . '/Fixture/PropertyUsedViaSubClass.php'], []];
+        yield [[__DIR__ . '/Fixture/StaticPropertyUsedViaSubClass.php'], []];
 
         $errorMessage = sprintf(UnusedPublicPropertyRule::ERROR_MESSAGE, LocalyUsedPublicProperty::class, 'name');
         yield [[__DIR__ . '/Fixture/LocalyUsedPublicProperty.php'],