Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ClassConstFetchCollector #122

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Fix ClassConstFetchCollector #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Collectors/ClassConstFetchCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public function processNode(Node $node, Scope $scope): ?array
if ($classReflection->hasConstant($constantName)) {
$constantReflection = $classReflection->getConstant($constantName);
$declaringClass = $constantReflection->getDeclaringClass();
if ($declaringClass->getFileName() !== $classReflection->getFileName()) {
if ($declaringClass->getName() !== $classReflection->getName()) {
Copy link
Contributor Author

@staabm staabm Jul 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its a typo, that this check uses the file-name instead of the class-name.

in files in which several classes are used in a single file, the previous check would not work.

none of the other *Collector classes uses getFileName()

return [$declaringClass->getName() . '::' . $constantName];
}

Expand Down
Loading