Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect public properties used via Subclass #123

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Detect public properties used via Subclass #123

merged 4 commits into from
Jul 22, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jul 19, 2024 •
edited
Loading

Utilize the declaring class, like we already do in ClassConstFetchCollector

@staabm staabm changed the title Detect public property used via Subclass Detect public properties used via Subclass Jul 19, 2024
@staabm staabm marked this pull request as ready for review July 19, 2024 10:04
@staabm
Copy link
Contributor Author

staabm commented Jul 19, 2024

should be good to go

@staabm
Copy link
Contributor Author

staabm commented Jul 22, 2024

Ping @TomasVotruba

@TomasVotruba
Copy link
Owner

Looks good, thank you 👍

@TomasVotruba TomasVotruba merged commit e96d688 into TomasVotruba:main Jul 22, 2024
8 checks passed
@staabm staabm deleted the fix2 branch July 22, 2024 08:14
@staabm
Copy link
Contributor Author

staabm commented Jul 22, 2024

thanks. would be great to get this released ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @TomasVotruba