-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extracted ClassTypeDetector
to ease re-use
#64
Conversation
$classReflection = $scope->getClassReflection(); | ||
if ($classReflection instanceof ClassReflection && $classReflection->isSubclassOf( | ||
'PHPUnit\Framework\TestCase' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before this PR, this check was missing PHPUnit_Framework_TestCase
@@ -14,17 +14,24 @@ final class PublicClassMethodMatcher | |||
* @var string[] | |||
*/ | |||
private const SKIPPED_TYPES = [ | |||
'PHPUnit\Framework\TestCase', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before this PR, this check was missing PHPUnit_Framework_TestCase
|
||
final class ClassTypeDetector | ||
{ | ||
public function isTestClass(ClassReflection $classReflection): bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after this PR, it will also be easier to integrate other test-frameworks, which use different base-classes.
just a matter of adjusting a single method in the repo as of now.
Thank you, I like this improvement 👍 |
preparation for #49
also fixes compat with older phpunit versions when
PHPUnit_Framework_TestCase
is used