-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test installation on PHP 8.2/8.3 #82
Conversation
@@ -16,6 +16,8 @@ jobs: | |||
- 7.2 | |||
- 8.0 | |||
- 8.1 | |||
- 8.2 | |||
- 8.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nette/utils does not yet support 8.3: nette/utils#297
@TomasVotruba locally tested with todays nette/utils 4.0.1 release. the testsuite is green. |
composer.json
Outdated
@@ -7,7 +7,7 @@ | |||
"require": { | |||
"php": "^8.1", | |||
"phpstan/phpstan": "^1.10.26", | |||
"nette/utils": "^3.2", | |||
"nette/utils": "^3.2 || ^4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be needed for downgraded install. It must pass without any package dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh good point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm but composer might not let you install the package because it cannot resolve dependencies..?
nette/utils declares php 8.3 compat as of 4.0.1. there is not php 8.3 compatible nette/utils 3.x release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should not happen.
Could you provide falling CI job? I'll check it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. It works in CI .. not sure why it didn‘t locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Composer sometimes get glitches with these non-standard tagging :)
The best way is to remove composer.lock and /vendor
.
No description provided.