Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve #54 clean up all dbt models except those materialised as incremental with append strategy #73

Merged
merged 1 commit into from
Jun 6, 2022
Merged

resolve #54 clean up all dbt models except those materialised as incremental with append strategy #73

merged 1 commit into from
Jun 6, 2022

Conversation

nialloriordan
Copy link
Contributor

@nialloriordan nialloriordan commented Mar 10, 2022 •
edited
Loading

Resolves #54

Currently, any tables that have a static external_location and are materialised as a table rather than incremental fail due to the underlying data not being cleaned up.

This is a minor fix to specify that only incremental tables that use the append approach are not cleaned up.

@oriordanniall
resolve Tomme#54
d67d848 
Tables not cleaned up if materialized = table
and static external location
This was referenced Mar 10, 2022
Closed
Closed
@nialloriordan nialloriordan changed the title resolve #54 when tables are not cleaned up due to materialisation as table resolve #54 clean up all dbt models except those materialised as incremental with append strategy Mar 16, 2022
skasai5296 added a commit to flywheel-jp/dbt-athena that referenced this pull request Jun 5, 2022
@skasai5296
apply Tomme#73
533917a
@skasai5296 skasai5296 mentioned this pull request Jun 5, 2022
Merged
skasai5296 added a commit to flywheel-jp/dbt-athena that referenced this pull request Jun 5, 2022
@skasai5296
apply Tomme#73 (#2)
5a6514f
@Tomme Tomme merged commit b641dad into Tomme:master Jun 6, 2022
@Tomme
Copy link
Owner

Tomme commented Jun 6, 2022

Thank you 🙏

@jessedobbelaere jessedobbelaere mentioned this pull request Jun 7, 2022
Open
@ojaved-equip ojaved-equip mentioned this pull request Jun 24, 2022
Open
@rmbrich rmbrich mentioned this pull request Aug 2, 2022
Closed
nicor88 referenced this pull request in dbt-labs/dbt-athena Nov 16, 2022
@nialloriordan @oriordanniall @nicor88
resolve #54 (#73)
2625e67 
Tables not cleaned up if materialized = table
and static external location

Co-authored-by: Niall O'Riordan <nialloriordan@fundingcircle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tables not cleaned up if materialized = table and static external location
3 participants
@nialloriordan @Tomme @oriordanniall